Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Zebra EOS halt in light of upcoming network upgrade #8514

Open
mpguerra opened this issue May 8, 2024 · 1 comment
Open

Review Zebra EOS halt in light of upcoming network upgrade #8514

mpguerra opened this issue May 8, 2024 · 1 comment
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-consensus Area: Consensus rule updates A-release Area: Zebra releases and release management C-research Category: Engineering notes in support of design choices I-consensus Zebra breaks a Zcash consensus rule NU-6 Network Upgrade: NU6 specific tasks S-needs-investigation Status: Needs further investigation

Comments

@mpguerra
Copy link
Contributor

mpguerra commented May 8, 2024

          We should revert and possibly decrease this value to ensure that there are no zebra versions running with old consensus rules after the end of the current protocol version which includes the devfund.

Originally posted by @mpguerra in #8429 (comment)

@mpguerra mpguerra added NU-6 Network Upgrade: NU6 specific tasks C-research Category: Engineering notes in support of design choices A-consensus Area: Consensus rule updates S-needs-investigation Status: Needs further investigation I-consensus Zebra breaks a Zcash consensus rule A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-release Area: Zebra releases and release management labels May 16, 2024
@mpguerra
Copy link
Contributor Author

mpguerra commented May 16, 2024

I'm not sure if we still need to do this now that we match zcashd again.

The only outstanding question is whether zcashd reduces the EOS halt as a network upgrade approaches or it just relies on the network upgrade activation height to ensure there are no nodes running with old consensus rules and whether we should follow that approach.

So, if my understanding is correct, this means that we need to ensure that if the EOS halt for a zebra release falls beyond the date when we estimate the next network upgrade height will hit we should either:

a. include the next network upgrade activation height and consensus rules within this release
b. reduce the EOS halt period to happen before the estimated date for the next network upgrade activation height.

As of today, there are ~26 weeks until the halving and potentially next network upgrade activation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-consensus Area: Consensus rule updates A-release Area: Zebra releases and release management C-research Category: Engineering notes in support of design choices I-consensus Zebra breaks a Zcash consensus rule NU-6 Network Upgrade: NU6 specific tasks S-needs-investigation Status: Needs further investigation
Projects
Status: Sprint Backlog
Development

No branches or pull requests

1 participant