Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main branch CI failed: push in Multi-OS Unit Tests #8499

Closed
github-actions bot opened this issue May 3, 2024 · 14 comments · Fixed by #8551
Closed

main branch CI failed: push in Multi-OS Unit Tests #8499

github-actions bot opened this issue May 3, 2024 · 14 comments · Fixed by #8551

Comments

@github-actions
Copy link

github-actions bot commented May 3, 2024

GitHub Actions workflow Multi-OS Unit Tests #1226 failed.

Event: push
Branch: main
Commit: 183249d2edf3d689b8f39c8bd7a2b5e6d4cb5e5a

Created by jayqi/failed-build-issue-action

@arya2
Copy link
Contributor

arya2 commented May 3, 2024

Copy link
Author

github-actions bot commented May 7, 2024

GitHub Actions workflow Multi-OS Unit Tests #1262 failed.

Event: push
Branch: main
Commit: 3e264c73a65079746d0c16ea4ee59ac0062f345e

Created by jayqi/failed-build-issue-action

Copy link
Author

github-actions bot commented May 7, 2024

GitHub Actions workflow Multi-OS Unit Tests #1264 failed.

Event: push
Branch: main
Commit: 0040c2be87a6ddbeb3ca60558accca1171787757

Created by jayqi/failed-build-issue-action

Copy link
Author

github-actions bot commented May 8, 2024

GitHub Actions workflow Multi-OS Unit Tests #1266 failed.

Event: push
Branch: main
Commit: 15e1096826532f8fbb9ebaa70fee0fd280fd29c0

Created by jayqi/failed-build-issue-action

@gustavovalverde
Copy link
Member

This issue relates to:

Seems like it needs some Rust code review from previous fixes

@oxarbitrage
Copy link
Contributor

oxarbitrage commented May 8, 2024

The test failing seems to be non_blocking_logger: https://github.com/ZcashFoundation/zebra/actions/runs/9003850454/job/24735443640#step:12:9013

This test seems to be already unreliable for macos: https://github.com/ZcashFoundation/zebra/blob/main/zebrad/tests/acceptance.rs#L1705

We might want to disable it for windows as well.

Copy link
Author

GitHub Actions workflow Multi-OS Unit Tests #1275 failed.

Event: push
Branch: main
Commit: a6569d4881d58b25f7f2f55a6b558144447bce4f

Created by jayqi/failed-build-issue-action

@arya2
Copy link
Contributor

arya2 commented May 13, 2024

@mpguerra
Copy link
Contributor

@gustavovalverde we should looking into why we're getting more port conflict issues in tests lately, e.g see #8525

@gustavovalverde
Copy link
Member

This has been (historically) a Windows tests issue. I can dig deeper into this, but maybe I should match with an Engineer to confirm if this is something that must be fix in Rust or in the Infrastructure.

@gustavovalverde gustavovalverde self-assigned this May 14, 2024
Copy link
Author

GitHub Actions workflow Multi-OS Unit Tests #1300 failed.

Event: push
Branch: main
Commit: 0f5450f5650102aea1fff43ec88c065ef1976e79

Created by jayqi/failed-build-issue-action

@mpguerra
Copy link
Contributor

@arya2 can you take a look and sync up with @gustavovalverde on this one?

@arya2
Copy link
Contributor

arya2 commented May 16, 2024

It's a Rust issue. It can't use OS-assigned ports on Windows in the same way it does for Linux/maxOS, so it's picking random numbers in a range of ports that could be available.

@mpguerra
Copy link
Contributor

Let's disable this test for windows then and move on :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants