Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update target_difficulty_limit() and expected_difficulty returned by difficulty_time_and_history_tree() to match zcashd target difficulty for regtest #8479

Closed
Tracked by #7119
arya2 opened this issue Apr 30, 2024 · 0 comments · Fixed by #8518
Closed
Tracked by #7119

Update target_difficulty_limit() and expected_difficulty returned by difficulty_time_and_history_tree() to match zcashd target difficulty for regtest #8479

arya2 opened this issue Apr 30, 2024 · 0 comments · Fixed by #8518
Assignees
@arya2
Labels
A-consensus Area: Consensus rule updates NU-6 Network Upgrade: NU6 specific tasks
Milestone
Regtest Network s...

Comments

@arya2
Copy link
Contributor

arya2 commented Apr 30, 2024 •
edited

Motivation

We want Zebra's Regtest to be compatible with the zcashd Regtest and align as closely as practical with the Mainnet consensus rules.

zcashd target difficulty for regtest - There's also a TODO for the required value in the Network::target_difficulty_limit() method
@arya2 arya2 mentioned this issue Apr 30, 2024
Open
11 tasks
@arya2 arya2 changed the title Update and returned by to match Update target_difficulty_limit() and expected_difficulty returned by difficulty_time_and_history_tree() to match zcashd target difficulty for regtest Apr 30, 2024
@arya2 arya2 added this to the Regtest Network support milestone Apr 30, 2024
@arya2 arya2 changed the title Update target_difficulty_limit() and expected_difficulty returned by difficulty_time_and_history_tree() to match zcashd target difficulty for regtest Update target_difficulty_limit() and expected_difficulty returned by difficulty_time_and_history_tree() to match zcashd target difficulty for regtest Apr 30, 2024
@arya2 arya2 added A-consensus Area: Consensus rule updates S-blocked Status: Blocked on other tasks NU-6 Network Upgrade: NU6 specific tasks and removed S-blocked Status: Blocked on other tasks labels Apr 30, 2024
@arya2 arya2 self-assigned this May 10, 2024
@arya2 arya2 mentioned this issue May 10, 2024
Merged
9 tasks
@mergify mergify bot closed this as completed in #8518 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arya2 arya2

Labels
A-consensus Area: Consensus rule updates NU-6 Network Upgrade: NU6 specific tasks
Projects
Zebra
Status: Done
Milestone
Regtest Network support
Development

Successfully merging a pull request may close this issue.

add(consensus): Add a target_difficulty_limit field on testnet::Parameters ZcashFoundation/zebra
1 participant
@arya2