Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove git dependency on lexical-core #2881

Closed
1 task
teor2345 opened this issue Oct 14, 2021 · 2 comments
Closed
1 task

Remove git dependency on lexical-core #2881

teor2345 opened this issue Oct 14, 2021 · 2 comments
Labels
A-dependencies Area: Dependency file updates
Projects
🦓

Comments

@teor2345
Copy link
Contributor

Motivation

We moved to a git dependency on:

lexical-core 0.7.4 was incompatible with rustc nightly >= ~2021-03-24, see rust-lang/rust#81654

Suggested Solution

  • remove patch once zcash_script and rocksdb transitively depend on lexical-core >= 0.7.5
@teor2345 teor2345 added A-dependencies Area: Dependency file updates S-needs-triage Status: A bug report needs triage labels Oct 14, 2021
@teor2345 teor2345 added this to the 2021 Sprint 21 milestone Oct 14, 2021
@zfnd-bot zfnd-bot bot added this to To Do in 🦓 Oct 14, 2021
@teor2345
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with ZenHub @dconnolly @oxarbitrage @upbqdn @conradoplg

@mpguerra mpguerra added the P-Low label Oct 18, 2021
@teor2345
Copy link
Contributor Author

This seems to have been fixed some time ago.

🦓 automation moved this from To Do to Done Oct 24, 2021
@teor2345 teor2345 removed this from the 2021 Sprint 21 milestone Oct 24, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Area: Dependency file updates
Projects
No open projects
🦓
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpguerra @teor2345