We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is your feature request related to a problem? Please describe.
tower-batch ignores semaphore errors, but tower::Buffer handles them: https://github.com/ZcashFoundation/zebra/blob/main/tower-batch/src/service.rs#L97 https://docs.rs/tower/0.4.4/src/tower/buffer/service.rs.html#124
tower-batch
tower::Buffer
Describe the solution you'd like
We should stop returning Poll::Ready(Ok(())) when the semaphore errors.
Poll::Ready(Ok(()))
Instead, we should return the semaphore errors, mapping them as needed:
self.semaphore .poll_acquire(cx) .map_err(|_| self.get_worker_error())
Describe alternatives you've considered
Do nothing: the code hides any semaphore errors, but continues to fail internally.
Additional context
These hidden failures could be causing hangs, so this issue is a high priority.
This issue was discovered during the review in #1593. It could be a cause of the hangs or CPU usage in #1435 or #1634, so it's a high priority.
The text was updated successfully, but these errors were encountered:
oxarbitrage
Successfully merging a pull request may close this issue.
Is your feature request related to a problem? Please describe.
tower-batch
ignores semaphore errors, buttower::Buffer
handles them:https://github.com/ZcashFoundation/zebra/blob/main/tower-batch/src/service.rs#L97
https://docs.rs/tower/0.4.4/src/tower/buffer/service.rs.html#124
Describe the solution you'd like
We should stop returning
Poll::Ready(Ok(()))
when the semaphore errors.Instead, we should return the semaphore errors, mapping them as needed:
Describe alternatives you've considered
Do nothing: the code hides any semaphore errors, but continues to fail internally.
Additional context
These hidden failures could be causing hangs, so this issue is a high priority.
This issue was discovered during the review in #1593. It could be a cause of the hangs or CPU usage in #1435 or #1634, so it's a high priority.
The text was updated successfully, but these errors were encountered: