Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform to OAS3 unconditionally to satisfy swagger #27

Open
joostd opened this issue May 3, 2023 · 1 comment
Open

Conform to OAS3 unconditionally to satisfy swagger #27

joostd opened this issue May 3, 2023 · 1 comment

Comments

@joostd
Copy link
Collaborator

joostd commented May 3, 2023

Swagger complains about errors in our OpenAPI 3.0 Webauthn Schema

Semantic error at paths./v1/user.delete.requestBody
DELETE operations cannot have a requestBody.
Semantic error at paths./v1/user/credentials.delete.requestBody
DELETE operations cannot have a requestBody.

Swagger seems to have started to raise errors to conform to OAS3.
Their documentation states:

"GET, DELETE and HEAD are no longer allowed to have request body because it does not have defined semantics as per RFC 7231."

Although the OAS3 specs say:

"requestBody is permitted but does not have well-defined semantics and SHOULD be avoided if possible."

Do we need to change this in order to conform unconditionally?

@dmennis
Copy link
Contributor

dmennis commented Jun 21, 2023

DELETE - /v1/user/credentials/{credentialId}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants