Skip to content

chore(LineContext): add deprecated warning to some methods #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

chentsulin
Copy link
Collaborator

  • context.useAccessToken
  • context.replyButtonTemplate
  • context.push
  • context.pushText
  • context.pushImage
  • context.pushVideo
  • context.pushAudio
  • context.pushLocation
  • context.pushSticker
  • context.pushImagemap
  • context.pushFlex
  • context.pushTemplate
  • context.pushButtonTemplate
  • context.pushButtonsTemplate
  • context.pushConfirmTemplate
  • context.pushCarouselTemplate
  • context.pushImageCarouselTemplate
  • context.send
  • context.sendImage
  • context.sendVideo
  • context.sendAudio
  • context.sendLocation
  • context.sendSticker
  • context.sendImagemap
  • context.sendFlex
  • context.sendTemplate
  • context.sendButtonTemplate
  • context.sendButtonsTemplate
  • context.sendConfirmTemplate
  • context.sendCarouselTemplate
  • context.sendImageCarouselTemplate

@chentsulin chentsulin force-pushed the line-method-deprecated branch from 9e8022c to b17aa52 Compare October 11, 2021 03:38
@codecov-commenter
Copy link

Codecov Report

Merging #931 (b17aa52) into master (fb8e63f) will decrease coverage by 0.16%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
- Coverage   84.22%   84.06%   -0.17%     
==========================================
  Files         123      123              
  Lines        6320     6350      +30     
  Branches     1622     1622              
==========================================
+ Hits         5323     5338      +15     
- Misses        988     1008      +20     
+ Partials        9        4       -5     
Impacted Files Coverage Δ
packages/bottender/src/line/LineContext.ts 72.86% <50.00%> (-2.87%) ⬇️
packages/bottender/src/shared/getClient.ts 52.63% <0.00%> (ø)
packages/create-bottender-app/src/shared/log.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb8e63f...b17aa52. Read the comment docs.

@chentsulin chentsulin merged commit f25476d into master Oct 11, 2021
@chentsulin chentsulin deleted the line-method-deprecated branch October 11, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants