Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor website specific scriptdata to its own object #21351

Open
thijsoo opened this issue Apr 30, 2024 · 0 comments · May be fixed by #21368
Open

Refactor website specific scriptdata to its own object #21351

thijsoo opened this issue Apr 30, 2024 · 0 comments · May be fixed by #21368

Comments

@thijsoo
Copy link
Contributor

thijsoo commented Apr 30, 2024 •
edited

In the greater refactor of the script data we need to isolate the fields that are mostly just website settings,
This might include
+ siteIconUrl
+ linkParams
+ PluginUrl
+ DismissedAlerts
+ currentPromotions
+ Schema
+ site_name
+ wistiaEmbedPermission
+ webinarIntroBlockEditorUrl
+ blackFridayBlockEditorUrl
@thijsoo thijsoo self-assigned this Apr 30, 2024
@thijsoo thijsoo linked a pull request May 6, 2024 that will close this issue
Move generic site data into self contained objects. #21368
Open
18 tasks
@thijsoo thijsoo removed their assignment May 7, 2024
@leonidasmi leonidasmi assigned leonidasmi and thijsoo and unassigned leonidasmi May 27, 2024
@thijsoo thijsoo removed their assignment May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move generic site data into self contained objects. Yoast/wordpress-seo
2 participants
@thijsoo @leonidasmi