Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yoast\WP\SEO\should_index_indexables filter doesn't disable indexables #20335

Closed
monbauza opened this issue May 19, 2023 · 11 comments · Fixed by #21335
Closed

Yoast\WP\SEO\should_index_indexables filter doesn't disable indexables #20335

monbauza opened this issue May 19, 2023 · 11 comments · Fixed by #21335

Comments

@monbauza
Copy link

Please give us a description of what happened

The Yoast\WP\SEO\should_index_indexables filter allows users to disable the creation of indexables. See devs documentation. The filter doesn't work as indexables are still being created when the filter is set to false.

To Reproduce

Step-by-step reproduction instructions

  1. Install and activate Yoast SEO
  2. Add this filter to the theme functions.php file: add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );
  3. Create a new post
  4. Inspect the wp_yoast_indexable table in the database

Expected results

No indexable to be created for the new post.

Actual results

An indexable is created for the new post.

Used versions

  • WordPress version: 6.2.1
  • WordPress Theme: Twenty Twenty-Two
  • Yoast SEO version: 20.7
@monbauza
Copy link
Author

@monbauza
Copy link
Author

+1 HS Ticket 1014859

@amboutwe
Copy link
Member

Please inform the customer of conversation # 1050040 when this conversation has been closed.

@amboutwe
Copy link
Member

Please inform the customer of conversation # 1065670 when this conversation has been closed.

1 similar comment
@VictoriaMcCarter
Copy link

Please inform the customer of conversation # 1065670 when this conversation has been closed.

@suascat
Copy link

suascat commented Apr 1, 2024

Please inform the customer of conversation # 1117690 when this conversation has been closed.

@Pcosta88
Copy link
Contributor

Pcosta88 commented Apr 1, 2024

Following.

@rsdkrasen
Copy link

any update?

@josevarghese
Copy link
Contributor

Hi @rsdkrasen

Thanks for the comment. We've escalated this issue to our development team, and they will included it in our upcoming sprints. Our product team will assess the severity of this problem in relation to other open bug reports and new features. Based on their assessment, the bug report will be given a priority level. Our developers work on the highest priority issues first. Unfortunately, this means we cannot give you an estimate of when they'll start working on your report.

Thanks for your patience.

@leonidasmi
Copy link
Contributor

The PRs are ready for a review, but we have a couple of questions that need to be answered first from the product team before moving the ticket in Needs Review. Will come back to this shortly, once we have them answered.

@coatezy
Copy link

coatezy commented May 31, 2024

Looking forward to seeing this one resolved. I currently have to use the test helper plugin to reset the indexables on term and post save as the domain where posts are created is different to where the blog is served (behind a proxy).

$yoast_seo = new \Yoast\WP\Test_Helper\WordPress_Plugins\Yoast_SEO();
$yoast_seo->reset_feature('reset_indexables');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet