Don't overwrite user settings when the respective features are disabled #21314
+183
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
The user settings that we're interested in, along with their relations with global settings, are:
Enable author archives
global settingEnable author archives
global feature settingSEO analysis
global feature setting is enabledReadability analysis
global feature settingInclusive language analysis
global feature settingAccording to the above, for every setting the test is
Enable author archives
(or any of the other respective global feature settings, mentioned above)Show Toolbar when viewing site
setting )Enable author archives
settingWith this PR/RC:
Before this PR/RC:
Relevant test scenarios
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Title to use for Author page
):title
field to be the one we have in the user profile, no matter if the respective global setting is enabled or not.Meta description to use for Author page
):description
field to be the one we have in the user profile, no matter if the respective global setting is enabled or not.Do not allow search engines to show this author's archives in search results
):is_robots_noindex
field to be the one we have in the user profile, no matter if the respective global setting is enabled or not.Disable SEO analysis
):Disable SEO analysis
checkbox has been checked or not. Try while toggling the global SEO analysis feature as well.Disable inclusive language analysis
):Disable inclusive language analysis
checkbox has been checked or not. Try while toggling the global inclusive language feature as well.Disable readability analysis
):Disable readability analysis
checkbox has been checked or not. Try while toggling the global readability analysis feature as well.UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes #21313