Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whip_RequirementsChecker::addRequirement() loses requirements #31

Open
schlessera opened this issue Mar 8, 2017 · 0 comments
Open

Whip_RequirementsChecker::addRequirement() loses requirements #31

schlessera opened this issue Mar 8, 2017 · 0 comments
Labels
enhancement

Comments

@schlessera
Copy link
Contributor

The Whip_RequirementsChecker::addRequirement() method only adds requirements for a component if that component has not yet been added.

This should first compare the version requirements when dealing with duplicate components, and only keep the most strict version requirement.

Otherwise, if you add php >= 5.2 and then php >= 5.6, the 5.6 requirement is skipped because the component php was already added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schlessera @atimmer