Fix using SignTool options

[YehudaKremer]

Hello @zobo

In this PR I'm trying to fix problems with SignTool.

this PR includes the changes:

1. user can use SignTool freely as the office documentation instructing
2. when trying to sign with an installed certificate by using one of the options '/n', '/i' and '/sha1', this package will try to extract the certificate Subject with PowerShell script you provided

About .crt, I don't think SignTool supports .crt files, if I am wrong can you please provide me an example, thanks.

I would appreciate it if you could go through the changes in your spare time 👍

[zobo]

The PR looks good, indeed the simple split by space caused issues when I was experimenting. I like the use of extensions.

Regarding CRT. The docs say:

/f SignCertFile
Specifies the signing certificate in a file. If the file is in Personal Information Exchange (PFX) format and protected by a password, use the /p option to specify the password. If the file does not contain private keys, use the /csp and /kc options to specify the CSP and private key container name.

My experience is that if I provide a .crt file, the SignTool will figure out what private key to use. I did not need to add /csp and /kc options.

I'd suggest to also look for the case where a certificate file is provided, but no password and then extract the subject via:
new-object System.Security.Cryptography.X509Certificates.X509Certificate2("..\file.crt") | select -expandproperty Subject -First 1

I'll try to provide the code, but I'll be leaving for a week of travel soon.

[zobo]

I suggest you store the image into this GitHub repository and link to it via a commit url - to make it permanent.

[YehudaKremer]

done here 1149448

[zobo]

Quick dry code - have not tested it....

else if (_config.certificatePath != null)  {
  subject = await _getCrtCertificateSubject();
}

  Future<String> _getCrtCertificateSubject() async {
    _logger.trace('getting crt certificate Subject');

    var certificateDetailsProcess = await _executePowershellCommand(
        "new-object System.Security.Cryptography.X509Certificates.X509Certificate2(\"${_config.certificatePath}\") | select -expandproperty Subject -First 1
");

    certificateDetailsProcess.exitOnError();

    var subject = (certificateDetailsProcess.stdout as String).trim();

    return subject;
  }

[YehudaKremer]

done here: b252a98

[YehudaKremer]

also added the documentation bc0d17e

[YehudaKremer]

Good notes and examples,
I will add them to this branch soon as possible.

Thank You! 👍

[YehudaKremer]

Hello @zobo

I publish a new version (3.7.0) with these changes:

• https://github.com/YehudaKremer/msix/releases/tag/3.7.0
• https://pub.dev/packages/msix/versions/3.7.0

Thank you!

[zobo]

Looks like everything is working great. Thank you again!