Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple verification clobbers index #281

Closed
Xunnamius opened this issue Dec 1, 2021 · 2 comments
Closed

Simple verification clobbers index #281

Xunnamius opened this issue Dec 1, 2021 · 2 comments
Assignees
@Xunnamius
Labels
bug Something isn't working

Comments

@Xunnamius
Copy link
Owner

Problematic behavior

Simple verification does not respect git index state and will re-add the affected files, potentially clobbering the index.

Reproduction steps
  1. Use git add -p to partially stage file
  2. Use gac with simple verification
  3. The commit will succeed but the entire file from step 1 will have been staged instead (index clobbered).
Expected behavior
Additional context
@Xunnamius Xunnamius added the bug Something isn't working label Dec 1, 2021
@Xunnamius Xunnamius self-assigned this Dec 1, 2021
@Xunnamius
Copy link
Owner Author

Seems this might actually be a problem with lint-staged instead of this package. Requires further investigation.

@Xunnamius
Copy link
Owner Author

This issue was resolved upstream 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xunnamius Xunnamius

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Xunnamius