Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePoolName pattern should be customizable #75

Open
tothadi opened this issue Feb 21, 2024 · 4 comments
Open

nodePoolName pattern should be customizable #75

tothadi opened this issue Feb 21, 2024 · 4 comments

Comments

@tothadi
Copy link

tothadi commented Feb 21, 2024

The pattern for nodePoolName is currently hardcoded which prevents us from using this tool. Our ASGs doesn't have the "eks-" prefix in their names and renaming them would be a major pain in the a**.

@bittrance
Copy link

I see. Can you share what pattern you would like for your specific case? I'm trying to understand if the best way to address this would be to allow configuring the whole pattern, or whether the pattern should be amended (presumably with the UUID pattern)?

@tothadi
Copy link
Author

tothadi commented Feb 23, 2024

Thanks for picking up on this.
E.g. we have an ASG with the name k8s_stage2-bd-scanner-12022110415025032090000000a and we got the runtime error:

"error":"could not find status for node pool: eks-k8s_stage2-bd-scanner-12022110415025032090000000a-[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}"

IMO the whole pattern should be configurable.

@TheDoctor028
Copy link

I've created a quick PR according to the feature description provided by @tothadi.

#76

This should make the use case more clear.

@phillebaba
Copy link
Contributor

Sorry for being late in the game. I am trying to figure out if I have done something wrong with the AWS specific handling that we should modify instead.

@TheDoctor028 your PR is it adding custom labeling for AWS specifically or some other cloud provider?

If we can the best option would be to just add specific support for each cloud provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants