New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom tag name support #42

Open

aleksander-raskin opened this issue May 9, 2023 · 1 comment

aleksander-raskin commented May 9, 2023 •

edited

Hello,
We want to use node-ttl on AKS, but Azure have tag name limitation and as a result not allowing to add /

Solution will be to have an override parameter for tags:

NodeTtlLabelKey
ScaleDownDisabledKey
PodSafeToEvictKey

Thanks

The text was updated successfully, but these errors were encountered:

Contributor

phillebaba commented May 9, 2023

Node TTL does not look at Azure tags, it looks at Kubernetes Node labels. Check how we do it with Terraform.
https://github.com/XenitAB/terraform-modules/blob/ff8578122360826e4e97bb68c2e37c1f437d9cc1/modules/azure/aks/aks.tf#L112

We have been using Node TTL in AKS for a while no so it should work without any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment