Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elasticsearch] Add degraded health status #287

Closed
inkel opened this issue Oct 1, 2019 · 3 comments
Closed

[Elasticsearch] Add degraded health status #287

inkel opened this issue Oct 1, 2019 · 3 comments

Comments

@inkel
Copy link
Contributor

inkel commented Oct 1, 2019

I was looking at the code of the Elasticsearch health check and found that it's using a simple ping to test whether Elasticsearch is up or not, which is not bad, but I was thinking that it would be nice to have it actually using the cluster health API in Elasticsearch and report healthy for green, unhealthy for red, and degraded for yellow.

The reason why I think degraded is right for the yellow state, and not green as it currently is, is because this could mean that some writes might take time to replicate (or even get lost if something happens to the cluster before replication is done).

Another option could be to add an extra parameter to ElasticsearchOptions to indicate you want to use degraded for yellow, or otherwise use the regular check that currently exists.

Would you be interested in something like this? If so, I've already some local custom health that does something like this.

@unaizorrilla
Copy link
Collaborator

A PR is welcome for this!!

@inkel
Copy link
Contributor Author

inkel commented Nov 14, 2019

PR #290 adds this feature!

@sungam3r
Copy link
Collaborator

fixed by #1577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants