Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG and pyproject.toml to 1.7.0 #451

Merged
merged 3 commits into from Oct 12, 2022
Merged

Conversation

JST5000
Copy link
Collaborator

@JST5000 JST5000 commented Oct 12, 2022

High Level Overview of Change

Title says it all

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated

### Fixed:
- Typing for factory classmethods on models
- Use properly encoded transactions in `Sign`, `SignFor`, and `SignAndSubmit`
- Fix Sphinx build errors due to incompatible version bumps
- AuthAccount models no longer need their `account` paramter to be capitalized (it was mismatched with rippled)
Copy link
Collaborator

@mvadari mvadari Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this an AMM-specific thing? Which hasn't been merged into master yet?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct - sorry I got confused with the two branches (I just saw the PR was merged and forgot there was a separate beta branch)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're just trying to see the PRs that have been added to the master branch, you can do something like this: v1.6.0...master

@connorjchen connorjchen self-requested a review October 12, 2022 17:32
Copy link
Collaborator

@connorjchen connorjchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdp2121 pdp2121 self-requested a review October 12, 2022 17:32
Copy link
Collaborator

@pdp2121 pdp2121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JST5000 JST5000 merged commit 5598bbe into master Oct 12, 2022
@JST5000 JST5000 deleted the xrpl-py-release branch October 12, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants