New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG and pyproject.toml to 1.7.0 #451
Conversation
CHANGELOG.md
Outdated
|
||
### Fixed: | ||
- Typing for factory classmethods on models | ||
- Use properly encoded transactions in `Sign`, `SignFor`, and `SignAndSubmit` | ||
- Fix Sphinx build errors due to incompatible version bumps | ||
- AuthAccount models no longer need their `account` paramter to be capitalized (it was mismatched with rippled) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this an AMM-specific thing? Which hasn't been merged into master
yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct - sorry I got confused with the two branches (I just saw the PR was merged and forgot there was a separate beta branch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're just trying to see the PRs that have been added to the master branch, you can do something like this: v1.6.0...master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
High Level Overview of Change
Title says it all