New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add xrpl.js code snippets over to xrpl-py #443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
reviewed
Sep 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would write these with the JsonRpcClient
(unless you want to write a snippet with each client, which seems like too much).
mvadari
reviewed
Sep 23, 2022
mvadari
reviewed
Sep 26, 2022
mvadari
reviewed
Sep 26, 2022
JST5000
reviewed
Sep 26, 2022
JST5000
reviewed
Sep 26, 2022
JST5000
reviewed
Sep 26, 2022
JST5000
reviewed
Sep 26, 2022
JST5000
reviewed
Sep 26, 2022
JST5000
reviewed
Sep 26, 2022
JST5000
reviewed
Sep 26, 2022
mvadari
reviewed
Sep 27, 2022
mvadari
reviewed
Sep 27, 2022
mvadari
reviewed
Sep 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of notes:
- Please add a multisign snippet (this could be in a separate PR if you'd prefer)
- Please add these as tests (this would probably best done by importing the file in a test, since the file will run when it's imported)
mvadari
reviewed
Oct 3, 2022
mvadari
reviewed
Oct 3, 2022
mvadari
approved these changes
Oct 3, 2022
jonathanlei
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Ported xrpl.js code snippets over to xrpl-py
Context of Change
Code snippets are a great way for developers in the community to learn from
Type of Change
Test Plan
Ran each file individually (claim_payment_channel fails because missing hashing function now)