refactor: create new abstract model for nested dict objects #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckniffen
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Some objects are of the form:
xrpl-py abstracts this away and creates the outer dictionary for you. There are a few objects that do this (
Memo,Signer, andSignerList). There is a lot of copy-pasted code between these 3 objects. This PR seeks to simplify that by creating a parent object that inherits from BaseModel that handles this extra code.Context of Change
I have a draft PR that has a few more of these objects, and it avoids having copy-pasted code.
Type of Change
Test Plan
CI passes. No change in functionality.