feat: add support for ED25519 seeds that don't use the sEd prefix
#415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckniffen
approved these changes
Jul 6, 2022
mvadari
force-pushed
the
ed-wallet
branch
2 times, most recently
from
ccc27e7
to
de3687e
Compare
JST5000
reviewed
Jul 19, 2022
JST5000
reviewed
Jul 19, 2022
JST5000
reviewed
Jul 19, 2022
intelliot
reviewed
Jul 20, 2022
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The library currently assumes that all
ed25519seeds use thesEdprefix. However, this is not necessarily true - they can also just have thesprefix, like thesecp256k1seeds.This PR adds support for those
ed25519seeds.Context of Change
needed for sidechains work
Type of Change
Test Plan
CI passes. Added tests to test the new functionality.