Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility function to get balance changes from transaction metadata #298

Closed
mDuo13 opened this issue Nov 8, 2021 · 1 comment
Closed

Utility function to get balance changes from transaction metadata #298

mDuo13 opened this issue Nov 8, 2021 · 1 comment
Labels

Comments

@mDuo13
Copy link
Collaborator

mDuo13 commented Nov 8, 2021

The getBalanceChanges() method of xrpl.js makes it much easier for beginners to reliably get information about how a transaction affected their balances of XRP and tokens. Doing it "by hand" is error-prone and confusing since it involves parsing a bunch of metadata, which has some sneaky edge cases, and RippleState nodes in particular, where the sign of the balance depends on which accounts are the high/low nodes.

It would be great to have a comparable function in xrpl-py.

It would also be nice to do getBalances() (which calls account_info and account_lines and does a little processing on the results) as well.

@mDuo13 mDuo13 added the enhancement New feature or request label Nov 8, 2021
@mvadari mvadari linked a pull request Jan 10, 2022 that will close this issue
@JST5000
Copy link
Contributor

JST5000 commented Jan 5, 2023

Completed by LimpidCrypto in #383

@JST5000 JST5000 closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants