Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow bootstrax --production for finished runs #965

Closed
JoranAngevaare opened this issue Mar 8, 2022 · 3 comments · Fixed by #1024
Closed

Don't allow bootstrax --production for finished runs #965

JoranAngevaare opened this issue Mar 8, 2022 · 3 comments · Fixed by #1024
Labels
bug Something isn't working

Comments

@JoranAngevaare
Copy link
Contributor

If we have already finished a run, we shouldn't be allowed to say bootstrax --production --process <finished_run> since it results in a "failure" since there is no live data anymore etc etc.
@JoranAngevaare JoranAngevaare added the bug Something isn't working label Mar 8, 2022
@JoranAngevaare
Copy link
Contributor Author

@mflierm , would you want to add a check that fails when bootstrax --production --process <finished_run> is specified? I think it's important we add this

@mflierm
Copy link
Contributor

mflierm commented Apr 20, 2022

Just tried something here, let me know what you think! :)

b3e1d91#commitcomment-71713357

@JoranAngevaare
Copy link
Contributor Author

fixed in #1024 by @mflierm

@JoranAngevaare JoranAngevaare linked a pull request Apr 21, 2022 that will close this issue
Check if processed data already exists in --production mode #1024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check if processed data already exists in --production mode XENONnT/straxen
2 participants
@JoranAngevaare @mflierm