Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arc-swap #48

Closed
dbanty opened this issue Dec 11, 2020 · 4 comments
Closed

Update arc-swap #48

dbanty opened this issue Dec 11, 2020 · 4 comments

Comments

@dbanty
Copy link

dbanty commented Dec 11, 2020

I get an error when attempting to install this package from cargo:

error: failed to select a version for the requirement `arc-swap = "^0.4.6"`
candidate versions found which didn't match: 1.1.0, 0.4.1, 0.4.0, ...
location searched: crates.io index
required by package `octocrab v0.8.1`

Looks like arc-swap 0.4.6 and 0.4.7 were yanked due to a soundness issue. Also looks like this project has already been updated to ^1.0.0 (which was also yanked, but 1.1.0 should be compatible?) and just needs to be re-released.

As a workaround I'm going to use a git dependency for now. Thanks!

@dbanty
Copy link
Author

dbanty commented Dec 11, 2020

For reference it looks like this happened as a result of vorner/arc-swap#45 just 30 minutes ago. Unlucky that I happened to try to install right after that.

@vorner
Copy link

vorner commented Dec 11, 2020

Crap, I didn't expect this consequence of yanking all the broken versions. But in hindsight, it makes complete sense. There doesn't seem to be a good way out of a soundness bug :-|.

Anyway, sorry for the disruption, I've backported the fix to the 0.4 version, just released as 0.4.8. So it should work now, hopefully.

(Not saying a release of octocrab wouldn't be nice)

@dbanty
Copy link
Author

dbanty commented Dec 11, 2020

Awesome, thanks @vorner! Confirmed it's all working by removing/re-adding octocrab's released version.

Since this isn't an immediate issue anymore I'll close this.

@dbanty dbanty closed this as completed Dec 11, 2020
@XAMPPRocky XAMPPRocky reopened this Dec 11, 2020
@XAMPPRocky
Copy link
Owner

I'm going to leave the issue open until I update the arc-swap dependency

@XAMPPRocky XAMPPRocky changed the title Error about arc-swap when installing Update arc-swap Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants