Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intl_migration: doesn't handle triple-quoted multi-line strings properly #153

Open
alanknight-wk opened this issue Jun 28, 2022 · 2 comments

Comments

@alanknight-wk
Copy link
Contributor

It generates a single-line, without a closing quote, and does not properly distinguish two similar large strings.

@alanknight-wk
Copy link
Contributor Author

I noticed it also doesn't handle strings with an explicit newline in them. This makes me think that the problem may not be with getting the data out of the analyzer, but with the way we generate it. Because when it fails I also see lines at the end of the file that look like the rest of the problem declaration. So maybe if there's a newline in the literal string something weird is happening with the way we do the output.

@matthewward-wf
Copy link
Contributor

Hmm, I bet this is where I do something along the lines of

  var lines = classFile.readAsLines();
  lines.sort();

Because I made the assumption that new lines would always be escaped, but that doens't hold true form triple quote strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants