Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require the frugal library to be cloned to generate go code #919

Open
brianshannan-wf opened this issue Sep 19, 2017 · 1 comment
Open

Comments

@brianshannan-wf
Copy link
Contributor

"Generated go files do not include the import "github.com/Workiva/frugal/lib/go" declaration unless you have a GOPATH setup with that lib, which should not be necessary for just the binary to run.
Steps to reproduce:

$ unset GOPATH
$ frugal --version # Just for the record here
frugal version 2.2.1
$ frugal --gen go example.frugal
$ cat gen-go/example/f_fooservice_service.go

and notice that f_fooservice_service.go is not a valid go file because it doesn't have import "github.com/Workiva/frugal/lib/go"."

This is because we run goimports on the generated output currently

@brianshannan-wf
Copy link
Contributor Author

After some investigation, this is used due to #100, so just removing goimports isn't a valid solution, we need to make sure all imports from other generated includes are used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant