We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I would have expected Frugal to explicitly type this as int16 in Go - https://github.com/Workiva/commitlog-frugal/blob/master/idl/commitlog_errors.frugal#L38 It produces an implicitly typed constant (in 2.2.0) - https://github.com/Workiva/commitlog-frugal/blob/master/go/gen/commitlog_frugal_api_errors/f_types.go#L40 . It just leads to some extra casts.
A field that is typed in the IDL as i16 is generated as int16, not int - https://github.com/Workiva/commitlog-frugal/blob/master/go/gen/commitlog_frugal_api_errors/f_types.go#L51 - so that seems a little inconsistent.
int16
int
The text was updated successfully, but these errors were encountered:
https://jira.atl.workiva.net/browse/MSG-432
Sorry, something went wrong.
No branches or pull requests
I would have expected Frugal to explicitly type this as int16 in Go - https://github.com/Workiva/commitlog-frugal/blob/master/idl/commitlog_errors.frugal#L38
It produces an implicitly typed constant (in 2.2.0) - https://github.com/Workiva/commitlog-frugal/blob/master/go/gen/commitlog_frugal_api_errors/f_types.go#L40 . It just leads to some extra casts.
A field that is typed in the IDL as i16 is generated as
int16, notint- https://github.com/Workiva/commitlog-frugal/blob/master/go/gen/commitlog_frugal_api_errors/f_types.go#L51 - so that seems a little inconsistent.The text was updated successfully, but these errors were encountered: