Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike: Bump react-virtual to the lastest v3 #2663

Open
3 tasks
alanbsmith opened this issue Mar 25, 2024 · 0 comments
Open
3 tasks

Spike: Bump react-virtual to the lastest v3 #2663

alanbsmith opened this issue Mar 25, 2024 · 0 comments
Labels
11.x

Comments

@alanbsmith
Copy link
Member

alanbsmith commented Mar 25, 2024 •
edited by jaclynjessup

馃挕 Suggestion

react-virtual v2 seems to work fine with React 18, but it has a lot of noisy console warnings. We should bump to the latest v3 which supports React 18 by default. This might be something we can do in v10 as a patch, but it might have to happen in v11 if there are breaking changes. react-virtual doesn't have a changelog or upgrade guide (that I could find), just this commit log. We'll need to work through the changes carefully so we don't break anything.

Tasks
Beta Give feedback
@vibdev vibdev mentioned this issue Mar 25, 2024
Open
@jaclynjessup jaclynjessup added this to the 11.0.0 milestone Mar 25, 2024
@alanbsmith alanbsmith changed the title Bump react-virtual to the lastest v3 Spike: Bump react-virtual to the lastest v3 Mar 28, 2024
@jaclynjessup jaclynjessup removed this from the 11.0.0 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
11.x
Projects
Canvas Kit
Status: 馃啎 New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alanbsmith @jaclynjessup