-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugins: Add "Community" and "Commercial" descriptions to search archives #308
Comments
My proposed mockup needs some design help, but what do you think of this approach @WordPress/meta-design? |
Yeah I think that could work nicely.
Agreed on both. |
I don't see the reason for adding the With that in mind, and in sync with #309, I would remove that text, place all search actions in one row, and include the category description. Here is a mockup gathering the three changes mentioned. |
That's the title ( |
So in that vein, do we need to update the all search results pages? If so, I then would like to go back to the idea shared previously that adds a sentence above the results grid. |
Based on this, I like your mockup @fcoveram. 👇 @StevenDufresne thoughts on moving forward with this iteration? Note this mockup does include the proposed changes in #309 |
The proper heading for a search results page should be "Search results" or "Search results for [term]", though. The production site is doing this correctly, now. Otherwise this has the same Maybe the headings can be combined to be "Community plugins: Search results for [term]" with the description under it? |
Could "Community plugins" be an |
I suppose (technically nothing wrong with it), but I feel like you're loosing half the context either way. Instead of only saying search results like production does now, it'll only (appear to) say "community plugins" — only screen reader users will get the benefit of full context. IMO it works on Patterns because there is no heading, so you look to the filters & breadcrumbs. Here, there is a heading, but it's not the full story, so it feels just as strange as the original issue. But this isn't a strong opinion, so feel free to outvote me. |
I think "Community plugins: Search results for [term]" could work well too. No stong opinions here either |
For me, this is the same conversion we are having in WordPress/wporg-mu-plugins#603 and it should be solved consistently across patterns/plugins/themes. I feel like we can do category education with a tooltip (assuming we can make it accessible). |
That's a cool idea! |
I like the idea. Do you have an idea for the "Learn more" link? I don't think we need it. |
The only place I can think to link to is the Make post 🤔 I am surprised there is no information (that I could find) in the WordPress.org Plugin Directory section of the Plugin Handbook. |
We could exclude it from the first iteration but I think it's valuable to have a place for plugins to visit that explains the categorizations along with how to categorize their plugin in the future. |
As a first step, I would love to see something like this when "test" is searched for:
This is similar to what is being done in the Patterns Directory. It doesn't solve all issues, but does provide more context to the search and should be easy to implement. |
That feels a great start to build on, and is hopefully easy to do. |
@ndiego's idea looks good. +1 to go with that. |
Follows the same decision in Plugins: WordPress/wordpress.org#308
Since the most recent refresh, there has been some discussion around the "Community" and "Commercial" categories. While these categories have been in place for quite some time, what stood out to me is that while there are descriptions on the category archives, there is no description on the search archive when you filter by either term.
I think adding the descriptions to the search archives when either term is selected would be helpful.
The text was updated successfully, but these errors were encountered: