Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Font sizes and weights in the sidebar #297

Open
jasmussen opened this issue Apr 30, 2024 · 2 comments
Open

Plugins: Font sizes and weights in the sidebar #297

jasmussen opened this issue Apr 30, 2024 · 2 comments

Comments

@jasmussen
Copy link

In the plugin sidebar, there appears to be a mix of font sizes and font weights:

Image

Note specifically the "Advanced View" (which could be "Advanced view") the font weight looks larger.

This sidebar from the forums design isn't a 1:1 design, but the principles are the same as far as font sizes, weights, styles, etc:

Image

Bonus: Replace the external link icon with ↗

@StevenDufresne
Copy link
Contributor

StevenDufresne commented May 1, 2024

What about taking the cue from the showcase component?

(Also noting this conversation about A11y with the current showcase sidebar. I think we could underline the links without causing much visual disruption.)

Screenshot 2024-05-01 at 3 54 56 PM

@jasmussen
Copy link
Author

Yes, I think it's okay to underline the links inside the sidebar module. I think there's more nuance in some of the showcase specific feature boxes that we could potentially make buttons instead of links inside boxes, but specifically for this issue and the example above, they can be the same I'd agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🛑 Pending discussion
Development

No branches or pull requests

3 participants