Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub integration: Pull upstream to fork before creating a PR #1396

Open
adamziel opened this issue May 14, 2024 · 0 comments
Open

GitHub integration: Pull upstream to fork before creating a PR #1396

adamziel opened this issue May 14, 2024 · 0 comments
Labels
[Feature] GitHub integration [Type] Bug An existing feature does not function as intended
Milestone

Comments

@adamziel
Copy link
Collaborator

Let's synchronize the upstream repo to personal fork before creating a PR via the "Export to GitHub" modal. Otherwise we'll soon start seeing conflicts in fresh PRs. There's some code to "synchronize the fork" at octokit/octokit.net#1833. I'm worried that could be slow, but slow is better than broken.

Context:

@adamziel adamziel added [Type] Bug An existing feature does not function as intended [Feature] GitHub integration labels May 14, 2024
@adamziel adamziel added this to the Zero Crashes milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] GitHub integration [Type] Bug An existing feature does not function as intended
Projects
Status: No status
Development

No branches or pull requests

1 participant