Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordCamp.org: cancelled camps visible with URL #602

Open
ghost opened this issue Aug 2, 2018 · 10 comments · May be fixed by #972
Open

WordCamp.org: cancelled camps visible with URL #602

ghost opened this issue Aug 2, 2018 · 10 comments · May be fixed by #972
Assignees
Labels
Migrated from Trac [Priority] Medium [Type] Good First Issue Straightforward, self-contained, doesn't require deep knowledge of codebase

Comments

@ghost
Copy link

ghost commented Aug 2, 2018

Imported from https://meta.trac.wordpress.org/ticket/3740
Created by @timiwahalahti:

For example, WC Rhode Island (post ID 3057593) is marked as "Cancelled", but still visible when accessing the URL https://central.wordcamp.org/wordcamps/wordcamp-ri-usa/. It shouldn't since it is canceled, right?

@ghost
Copy link
Author

ghost commented Oct 24, 2018

Comment by slackbot:

This ticket was mentioned in Slack in #meta-wordcamp by sippis. View the logs.

@ghost
Copy link
Author

ghost commented Oct 24, 2018

Comment by @iandunn:

  • Keywords set to Needs Patch Good First Bug
  • Status set to assigned
  • Owner set to @timiwahalahti

@ghost
Copy link
Author

ghost commented Oct 24, 2018

Comment by @timiwahalahti:

Today in WC bug scrub Ian said (note ro me for doing patch)

Probably just need to update that old theme template to use the new WordCamp_Loader::get_public_post_statuses()
(i'm not sure if i'm remembering the class/function name exactly right, but it's something similar to that)

@ghost
Copy link
Author

ghost commented Jan 5, 2019

Comment by @timiwahalahti:

  • Keywords set to Good First Bug Has Patch Needs Testing

This was a somewhat larger issue than I expected. Looks like you can access to every WordCamp info page on central.wordcamp.org regardless of its status.

Does every old WordCamp have a status? In WME WC's didn't have any status so also valid old camps did start giving a 404. A quick look on the production version WC list gives a feeling that every camp has a status, but this needs to be double-checked before applying the patch to production.

Patch extends existing query_public_statuses_on_archives function in wcpt plugin to limit singular WordCamp views on central.wordcamp.org/wordcamps/* to view only camps with public status. I extended the existing function to check also singular views, because it made more sense than adding a new check to new function.

@ghost
Copy link
Author

ghost commented Jan 5, 2019

Comment by @timiwahalahti:

@ghost
Copy link
Author

ghost commented Jan 5, 2019

Comment by slackbot:

This ticket was mentioned in Slack in #meta-wordcamp by sippis. View the logs.

@ghost
Copy link
Author

ghost commented Apr 23, 2019

Comment by @timiwahalahti:

@ghost
Copy link
Author

ghost commented Apr 23, 2019

Comment by @timiwahalahti:

Updated diff:

  • renamed function query_public_statuses_on_archives to query_public_statuses for consisteny
  • better inline documentation

@ghost
Copy link
Author

ghost commented Apr 23, 2019

Comment by @timiwahalahti:

@ghost
Copy link
Author

ghost commented May 16, 2019

Comment by slackbot:

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.

@ghost ghost added Migrated from Trac [Type] Good First Issue Straightforward, self-contained, doesn't require deep knowledge of codebase labels Sep 24, 2020
@timiwahalahti timiwahalahti self-assigned this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Migrated from Trac [Priority] Medium [Type] Good First Issue Straightforward, self-contained, doesn't require deep knowledge of codebase
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

2 participants