-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more performance-related checks #443
Comments
Thanks for opening this @swissspidy! +1 on brainstorming here which additional performance related checks could be valuable. cc @mukeshpanchal27 @joemcgill @westonruter @adamsilverstein Sharing further ideas here, some of which I dug up from an earlier design exploration from 1.5 years ago:
|
The corresponding PHPCS sniff does not yet support the new
We already have
I'd say this is impossible with static analysis, caching & query parts are not always co-located. So would need a runtime check. Could even be as simple as this:
Downside:
Hmm I could swear there was a ticket for this somewhere or even an existing sniff, but can't find anything right now 🤔 For a static check we'd need someone who's good at writing PHPCS sniffs. Some more performance sniffs from https://github.com/Automattic/VIP-Coding-Standards we're not currently using:
|
Right now the following performance-related checks or enhancements are proposed:
Ideally we'd have many more of those, so I am opening this issue for us to do some brainstorming.
The text was updated successfully, but these errors were encountered: