Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp-now: ifAlreadyInstalled does not work #260

Open
timofey-drozhzhin opened this issue May 9, 2024 · 2 comments
Open

wp-now: ifAlreadyInstalled does not work #260

timofey-drozhzhin opened this issue May 9, 2024 · 2 comments
Labels
Enhancement New feature or request wp-now

Comments

@timofey-drozhzhin
Copy link

ifAlreadyInstalled option previously introduced in WordPress/wordpress-playground#1244 does not seem to work.

Steps to reproduce

Create blueprint.json with the following:

{
  "$schema": "https://playground.wordpress.net/blueprint-schema.json",
  "steps": [
    {
      "step": "installPlugin",
      "pluginZipFile": {
        "resource": "wordpress.org/plugins",
        "path": "block-enhancements"
      },
      "ifAlreadyInstalled": "skip"
    }
  ]
}

and run wp-now start --blueprint=blueprint.json

Resulting error:

Screenshot 2024-05-09 at 3 24 37 AM
@adamziel
Copy link
Collaborator

@timofey-drozhzhin That's a wp-now issue so I'll move it to the playground-tools repo. Here's a Blueprint builder example where that attribute works. wp-now is a separate app and not a part of Playground core. I think updating the packages and releasing a new version would solve the problem here, I'm just not sure if it's a simple version bump or if there were any breaking Playground changes to accommodate.

Also, the Blueprint you've shared needs a minor adjustment: path should be slug.

@adamziel adamziel transferred this issue from WordPress/wordpress-playground May 13, 2024
@adamziel adamziel changed the title ifAlreadyInstalled does not work wp-now: ifAlreadyInstalled does not work May 13, 2024
@adamziel adamziel added Enhancement New feature or request wp-now labels May 13, 2024
@ryandejaegher
Copy link

@timofey-drozhzhin happy to hear I'm not the only one that ran into this issue.

@adamziel What is the distinction/separation between wp-now and WP Playground? I know wp-now is the npm/cli tool but I'm confused about why the updates don't happen in parallel.

I ran into issues in the earlier days of wp-now where the documentation on WP Playground talked about being able to run blueprint.json files but it took a bit for wp-now to catch up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request wp-now
Projects
None yet
Development

No branches or pull requests

3 participants