Playground plugin: % signs lost during the import

[adamziel]

This is what my Sandbox Site looks like:

I poked around a bit and the % is missing from flex-basis: 60% here:

[adamziel]

It's missing from the .sql database export

[adamziel]

Escaping values using wpdb prepare does something weird:

(await playground.run({
    code: `<?php require '/wordpress/wp-load.php'; var_dump($wpdb->prepare("60%")); `
})).text;
'string(68) "60{af9a6abec7c9b260e27aa2ace1c5391a7c553540c6e87b6723050d04230d874a}"\n'

[adamziel]

It's coming from the $wpdb->prepare call here:

playground-tools/packages/playground/src/playground-db.php

Lines 18 to 22 in 9c42b73

	if (is_numeric($value)) {
	$escaped[] = $wpdb->prepare('%d', $value);
	} else {
	$escaped[] = $wpdb->prepare('%s', $value);
	}

[bgrgicak]

I think that we should drop these prepares. The data is coming from SQL and going into SQL, if there is no way to change the data, we should be fine without prepares.

[adamziel]

@bgrgicak we still need to escape the values, say my database field contains a single quote or ends with a backslash.