Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground plugin: Doesn't work in Playground because of ZipStream dependency #235

Open
adamziel opened this issue Apr 16, 2024 · 0 comments
Labels
Bug Something isn't working Playground plugin

Comments

@adamziel
Copy link
Collaborator

Here's a few errors I stumbled upon when trying to run the Playground plugin inside Playground:

PHP 8.0:

[16-Apr-2024 21:52:18 UTC] PHP Parse error:  syntax error, unexpected identifier "Closure", expecting variable in /wordpress/wp-content/plugins/playground/vendor/maennchen/zipstream-php/src/ZipStream.php on line 111

PHP 8.3:

PHP Fatal error:  Uncaught ValueError: 64-bit format codes are not available for 32-bit versions of PHP in /wordpress/wp-content/plugins/playground/vendor/maennchen/zipstream-php/src/PackField.php:55

We already have a stream zip decoder written in PHP. Let's also port the TypeScript encoder to PHP 7.0–compatible code and use that instead.

@adamziel adamziel added Bug Something isn't working Playground plugin labels Apr 16, 2024
@adamziel adamziel added this to the Zero Crashes – Tools milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Playground plugin
Projects
Status: No status
Development

No branches or pull requests

1 participant