Images with partial transpency return "false" for "has-transparency"

[JacobDB]

Bug Description

Images that have partial transparency return false for has-transparency

Steps to reproduce

1. Upload a partially transparent image, such as this one
2. View the source code on the front end
3. Observer data-transparency="false" is added to the image

Screenshots

Additional Context

• PHP Version: 8.2.18
• OS: All
• Browser: All
• Plugin Version: Performance Lab 3.0.0, Image Placeholders v1.1.0
• Device: All

[westonruter]

From looking at the code it seems like this should be working correctly, where if alpha is zero then it is fully opaque:

performance/plugins/dominant-color-images/class-dominant-color-image-editor-gd.php

Lines 84 to 86 in 3febac9

	if ( $rgba['alpha'] > 0 ) {
	return true;
	}

performance/plugins/dominant-color-images/class-dominant-color-image-editor-imagick.php

Lines 86 to 88 in 3febac9

	if ( $color['a'] > 0 ) {
	return true;
	}

[JacobDB]

So are you saying that's intentional?

[westonruter]

No, but I'm confused why it isn't working for you because it seems to be coded correctly. It doesn't seem to be working for me either.

[JacobDB]

Interesting, glad it's not just me then! I did some more testing and yeah, it seems to be consistently occurring.

[westonruter]

I found the problem. I've proposed a fix in #1215. It's a one-line change you can easily test yourself.

[JacobDB]

Awesome, thanks much!