Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPStan errors being ignored should specify the error identifiers #1209

Closed
westonruter opened this issue May 9, 2024 · 0 comments · Fixed by #1213
Closed

PHPStan errors being ignored should specify the error identifiers #1209

westonruter opened this issue May 9, 2024 · 0 comments · Fixed by #1213
Assignees
@westonruter
Labels
skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature
Milestone
performance-lab 3...

Comments

@westonruter
Copy link
Member

westonruter commented May 9, 2024 •
edited

This is part of #775.

Feature Description

A new feature coming in PHPStan 1.11 is the ability to ignore specific errors rather than all errors on a given line:

image

We should implement this for the few places we have ignores in place:

performance/tests/includes/server-timing/perflab-server-timing-tests.php

Line 114 in 8b742ee

// @phpstan-ignore-next-line -- Ignored to test incorrect usage.

performance/tests/includes/server-timing/perflab-server-timing-tests.php

Line 126 in 8b742ee

// @phpstan-ignore-next-line -- Ignored to test incorrect usage.

performance/tests/plugins/webp-uploads/helper-tests.php

Line 382 in 8b742ee

/** @phpstan-ignore-next-line */

performance/tests/plugins/webp-uploads/image-edit-tests.php

Line 402 in 8b742ee

// @phpstan-ignore-next-line -- Work around PHPStan remembering the return value above being null but now being a string. This is instead of adding rememberPossiblyImpureFunctionValues:false to the config.

This will ensure we're only ignoring the error we expect. This is coming out next week!
@westonruter westonruter added the [Type] Enhancement A suggestion for improvement of an existing feature label May 9, 2024
@westonruter westonruter added this to the performance-lab 3.1.0 milestone May 9, 2024
This was referenced May 9, 2024
Closed
Merged
@westonruter westonruter self-assigned this May 14, 2024
@westonruter westonruter added the skip changelog PRs that should not be mentioned in changelogs label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonruter westonruter

Labels
skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
performance-lab 3.1.0
Development

Successfully merging a pull request may close this issue.

Update PHPStan to 1.11.1 WordPress/performance
1 participant
@westonruter