Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Check: Report WordPress.DB.DirectDatabaseQuery.DirectQuery warning for Autoloaded Options Health Check #919

Closed
mukeshpanchal27 opened this issue Jan 4, 2024 · 3 comments · Fixed by #1179
Closed

Plugin Check: Report WordPress.DB.DirectDatabaseQuery.DirectQuery warning for Autoloaded Options Health Check #919

mukeshpanchal27 opened this issue Jan 4, 2024 · 3 comments · Fixed by #1179
Labels
[Module] Audit Autoloaded Options Issues for the Audit Autoloaded Options Health Check module [Type] Bug An existing feature is broken
Milestone
performance-lab 3...

Comments

@mukeshpanchal27
Copy link
Member

Bug Description

The Plugin Check tool now shows warning for use of direct database call in Autoloaded Options Health Check.

Steps to reproduce

  1. Install Plugin Checker tool from https://github.com/WordPress/plugin-check repo
  2. Go to Tools > Plugin Check
  3. Select Performance Lab in Check the Plugin and click on Check it! button
  4. See error

Screenshots

Screenshot 2024-01-04 at 1 58 38 PM
@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken [Module] Audit Autoloaded Options Issues for the Audit Autoloaded Options Health Check module labels Jan 4, 2024
@Ellusu
Copy link
Contributor

Ellusu commented Apr 20, 2024

I'll handle that!

@mukeshpanchal27
Copy link
Member Author

Thanks @Ellusu Let me know if you need any support.

Ellusu added a commit to Ellusu/performance that referenced this issue Apr 24, 2024
@Ellusu
Update helper.php
9e88b17 
Ref issue: 919
WordPress#919
@Ellusu Ellusu mentioned this issue Apr 24, 2024
Merged
@Ellusu
Copy link
Contributor

Ellusu commented Apr 29, 2024

i have created this: #1179

@westonruter westonruter added this to the performance-lab 3.1.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Module] Audit Autoloaded Options Issues for the Audit Autoloaded Options Health Check module [Type] Bug An existing feature is broken
Projects
None yet
Milestone
performance-lab 3.1.0
3 participants
@westonruter @Ellusu @mukeshpanchal27