Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Placeholders not working #1169

Closed
tibor opened this issue Apr 21, 2024 · 2 comments
Closed

Image Placeholders not working #1169

tibor opened this issue Apr 21, 2024 · 2 comments
Labels
[Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) [Type] Bug An existing feature is broken

Comments

@tibor
Copy link

tibor commented Apr 21, 2024

Bug Description

I tried to use the Image Placeholders plugin for my website with custom theme, but it wouldn’t change anything in the frontend. Do I need to add anything to my code as well?

Additional Context

  • PHP Version: 8.1
  • OS: macOS
  • Browser: Chrome
  • Plugin Version: 1.1.0
  • Device: MacBook Air
@tibor tibor added the [Type] Bug An existing feature is broken label Apr 21, 2024
@westonruter
Copy link
Member

According to the readme:

This plugin determines and stores the dominant color for newly uploaded images in the media library within WordPress and then uses it to create a placeholder background of that color in the frontend, visible until the image is loaded.

So it only works for newly-uploaded images. Did you try uploading a new image to see if the placeholder background color is present?

Ideally preexisting images already uploaded to the media library would have their dominant color computed, such as via a WP Cron process. This is not implemented, however.

@westonruter westonruter added the [Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) label Apr 22, 2024
@adamsilverstein
Copy link
Member

Ideally preexisting images already uploaded to the media library would have their dominant color computed, such as via a WP Cron process. This is not implemented, however.

Regenerating images using wp-cli or a plugin should get the code to generate the placeholder images.

@westonruter westonruter closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) [Type] Bug An existing feature is broken
Projects
None yet
Development

No branches or pull requests

3 participants