Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URLPattern tests for Speculative Loading #1144

Open
westonruter opened this issue Apr 15, 2024 · 2 comments
Open

Add URLPattern tests for Speculative Loading #1144

westonruter opened this issue Apr 15, 2024 · 2 comments
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Speculative Loading Issues for the Speculative Loading plugin (formerly Speculation Rules)

Comments

@westonruter
Copy link
Member

Feature Description

As @tunetheweb noted in #1143 (comment), it would be useful if we could check the validity of the URLPattern strings that we're constructing in the Speculative Loading plugin to ensure they are valid.

@westonruter westonruter added Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Speculative Loading Issues for the Speculative Loading plugin (formerly Speculation Rules) labels Apr 15, 2024
@swissspidy
Copy link
Member

On that note, I was thinking about writing a JSON schema for speculation rules to ensure validity of that part too

@westonruter
Copy link
Member Author

Yeah, that'll be important especially if the entire rules array is filterable, as the schema could be checked even at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Speculative Loading Issues for the Speculative Loading plugin (formerly Speculation Rules)
Projects
Status: Not Started/Backlog 📆
Development

No branches or pull requests

2 participants