Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the Storybook stories to TypeScript #4290

Open
obulat opened this issue May 8, 2024 · 0 comments
Open

Convert the Storybook stories to TypeScript #4290

obulat opened this issue May 8, 2024 · 0 comments
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend ⛔ status: blocked Blocked & therefore, not ready for work

Comments

@obulat
Copy link
Contributor

obulat commented May 8, 2024

Problem

#4234 has converted all Storybook stories to stories.js format, which is supported by the newest version of Storybook. However, these stories are not type-checked.

Description

The stories should be converted to TypeScript after Nuxt 3 migration. We can split the changes into several PRs to make reviewing easier.

Alternatives

Additional context

Blocked by the Nuxt 3 migration.
@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users ⛔ status: blocked Blocked & therefore, not ready for work 🧱 stack: frontend Related to the Nuxt frontend labels May 8, 2024
@obulat obulat mentioned this issue May 8, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend ⛔ status: blocked Blocked & therefore, not ready for work
Projects
Openverse Backlog
Status: ⛔ Blocked
Milestone
No milestone
Development

No branches or pull requests
1 participant
@obulat