Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI + CD builds nginx image during API up #4289

Open
dhruvkb opened this issue May 8, 2024 · 0 comments · May be fixed by #4416
Open

CI + CD builds nginx image during API up #4289

dhruvkb opened this issue May 8, 2024 · 0 comments · May be fixed by #4416
Assignees
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API 🐳 tech: docker Involves Docker

Comments

@dhruvkb
Copy link
Member

dhruvkb commented May 8, 2024

Problem

The nginx image is always built in CI job "Run tests for the API". This is because the api/compose.yml does not have an image field in the nginx service, which forces it to be built when API is brought up.

Description

Add the field services.nginx.image to ensure that the image is built-once and cached and subsequently re-used.

Alternatives

Another alternative is to drop nginx and proxy from the API profile and let them be started manually by the developers who actually need to run them.

@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 🤖 aspect: dx Concerns developers' experience with the codebase 🐳 tech: docker Involves Docker 🧱 stack: api Related to the Django API labels May 8, 2024
@dhruvkb dhruvkb linked a pull request May 31, 2024 that will close this issue
8 tasks
@dhruvkb dhruvkb self-assigned this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API 🐳 tech: docker Involves Docker
Projects
Status: 🏗 In Progress
Development

Successfully merging a pull request may close this issue.

1 participant