Scripts: Update webpack config to allow modern image format #43880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow webp in wordpress plugins
niklasp
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
gziolo
changed the title
gziolo
added
[Package] Scripts
|
@niklasp, thank you for your contribution. It sounds like a necessary addition 👍🏻 |
gziolo
approved these changes
Sep 7, 2022
|
@niklasp, how did you test this change? |
|
have a 10k active install WordPress plugin and switched to wp scripts recently. had to do the above change to get my webp media successfully to the build folder |
|
Fair enough. Let's get this change in 👍🏻 |
|
😎 |
|
@niklasp While collecting props and credits for 6.1, it seems you are one of a few dozen folks that have not connected their WordPress.org account to their GitHub profile. Could you share your WordPress.org account so that we can ensure you're properly credited on the About page for WordPress 6.1? Connecting your accounts will also help those collecting this in the future. Thanks in advance! |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow webp in wordpress plugins
What?
just add webp to webpack config as module rule
Why?
people might want to include webp images in their packages to serve smaller plugin bundles