From c9b389972764fcade014ea039824814c1a9d1541 Mon Sep 17 00:00:00 2001 From: Mustaque Ahmed Date: Wed, 13 Jul 2022 19:32:52 +0530 Subject: [PATCH 1/4] handle case when status is null this commit is done to fix pipeline exit in case of failure. status value is `null` in case of failure --- packages/scripts/scripts/build.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/scripts/scripts/build.js b/packages/scripts/scripts/build.js index f1d101954e7cb..dddb71251ed64 100644 --- a/packages/scripts/scripts/build.js +++ b/packages/scripts/scripts/build.js @@ -8,6 +8,7 @@ const { sync: resolveBin } = require( 'resolve-bin' ); * Internal dependencies */ const { getWebpackArgs, hasArgInCLI, getArgFromCLI } = require( '../utils' ); +const EXIT_ERROR_CODE = 1; process.env.NODE_ENV = process.env.NODE_ENV || 'production'; @@ -30,4 +31,4 @@ process.env.WP_SRC_DIRECTORY = hasArgInCLI( '--webpack-src-dir' ) const { status } = spawn( resolveBin( 'webpack' ), getWebpackArgs(), { stdio: 'inherit', } ); -process.exit( status ); +process.exit( status || EXIT_ERROR_CODE ); From 26fcd744d1c1c178b0011b46627f46c6ec1f4cbe Mon Sep 17 00:00:00 2001 From: Mustaque Ahmed Date: Wed, 13 Jul 2022 20:09:23 +0530 Subject: [PATCH 2/4] fix OR condition --- packages/scripts/scripts/build.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/scripts/scripts/build.js b/packages/scripts/scripts/build.js index dddb71251ed64..714038fd80ee4 100644 --- a/packages/scripts/scripts/build.js +++ b/packages/scripts/scripts/build.js @@ -31,4 +31,4 @@ process.env.WP_SRC_DIRECTORY = hasArgInCLI( '--webpack-src-dir' ) const { status } = spawn( resolveBin( 'webpack' ), getWebpackArgs(), { stdio: 'inherit', } ); -process.exit( status || EXIT_ERROR_CODE ); +process.exit( status === null ? EXIT_ERROR_CODE : status ); From 3320451532df15bb27d28db47a15985b95e4576d Mon Sep 17 00:00:00 2001 From: Mustaque Ahmed Date: Wed, 13 Jul 2022 20:19:23 +0530 Subject: [PATCH 3/4] fix process.exit condition if status is `null` --- packages/scripts/scripts/start.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/scripts/scripts/start.js b/packages/scripts/scripts/start.js index 7c9aae9c143e6..862f11a4d6075 100644 --- a/packages/scripts/scripts/start.js +++ b/packages/scripts/scripts/start.js @@ -8,6 +8,7 @@ const { sync: resolveBin } = require( 'resolve-bin' ); * Internal dependencies */ const { getArgFromCLI, getWebpackArgs, hasArgInCLI } = require( '../utils' ); +const EXIT_ERROR_CODE = 1; if ( hasArgInCLI( '--webpack-no-externals' ) ) { process.env.WP_NO_EXTERNALS = true; @@ -36,4 +37,4 @@ const { status } = spawn( stdio: 'inherit', } ); -process.exit( status ); +process.exit( status === null ? EXIT_ERROR_CODE : status ); From 4821448c4c2cdf99a5ed79a7aaa4e8bd1039e56e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Greg=20Zi=C3=B3=C5=82kowski?= Date: Thu, 14 Jul 2022 09:38:10 +0200 Subject: [PATCH 4/4] Update CHANGELOG.md --- packages/scripts/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/scripts/CHANGELOG.md b/packages/scripts/CHANGELOG.md index 2fa9b192f7dcd..a221594293df1 100644 --- a/packages/scripts/CHANGELOG.md +++ b/packages/scripts/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +### Bug Fix + +- Fix the incorrect exit error code when status missing in `webpack` call for `build` and `start` commands ([#42396](https://github.com/WordPress/gutenberg/pull/42396)). + ## 23.3.0 (2022-06-15) ### Enhancements