Polish unset color indicator. #36994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
mtias
approved these changes
Nov 30, 2021
|
How does it look on the custom color button within the picker? |
|
Size Change: -71 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
Thanks for the check.
It still looks the same as before: I can take a look at that as well if you like. My instinct here would be to just have nothing, not even the diagonal, just a small gray border around the swatch. What are your thoughts there? |
We need to discriminate from "white" and "not set". Though perhaps that can be written in the place of the hex code. |
I haven't pushed this because it isn't a total success:
There's lots of fruit to be picked here, the "clear" button also isn't great. I think I'll land this PR on its own but can follow up on anything we decide per this. |
|
Yes, let's split that one into its own issue. |
|
@jasmussen don't forget the "backport to wp beta" label if you want your fixes to go into 5.9 :). (I assume it's the case for this one) |
youknowriad
added
the
Backport to WP Beta/RC
|
My apologies, I usually remember 🙈 Thank you. |
noisysocks
removed
the
Backport to WP Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 6, 2021
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small PR to change the transparency indication in the global styles color picker to look more "unset". Here's before:
Here's after:
This also matches the mockups:
How has this been tested?
Test a theme with some undefined text background or link colors.
Checklist:
*.native.jsfiles for terms that need renaming or removal).