Writing Flow: Double escape unselects all blocks #36945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
shaunandrews,
noisysocks,
talldan,
jameskoster,
jasmussen,
ellatrix and
kellychoffman
|
Size Change: +18 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Not a ton of code, yet such a profound improvement. This works excellently well for me:
Note that landing this doesn't preclude us from exploring further enhancements or changes. There are a few options listed on the thread, and we can continue to discuss there. But simply due to how basic this change is, and what a big impact it has, I think we should land this as a baseline and then explore from there.
Thank you Riad! With this landed, and #36798 hopefully shortly after, the biggest pain points with the site editor will have been addressed. That's incredible 👌
|
This is undoubtedly an improvement, but on its own I'm not convinced we can say that it closes #36535. It only "makes it easier" if you already know about the escape pattern, which isn't something the majority of users are likely to be aware of. |
|
@jameskoster let's reopen the issue in that case. Do you think this solution is good enough for 5.9 requirements or should we still come up with something else? |
|
I think Shaun's suggestions here would feel more natural for folks who are less keyboard-savvy, and could be worth trying if we have time:
I'll update the OP in #36535. |
3 tasks
noisysocks
pushed a commit
that referenced
this pull request
Nov 30, 2021
noisysocks
removed
the
Backport to WP Beta/RC
|
I don't think we should add the frame just yet. There's still some considerations left to be established around navigation that I think could be harmed by introducing this too early outside the focused template part context. |
|
I am pretty vocal about not having the frame as it becomes a visual distraction (and contrast) of an element that is not a part of the layout and also makes the layout real estate space smaller. It can also easily create confusion. It would be good to look for better solutions. |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #36535
This is especially important for the site editor where there's not much white space to click on.
Notes
Right now Space (or shift space) enter edit mode while in navigation mode, I'm happy to change these to match Craft's behavior if needed (inserter after/before) but could also be done separately and only add this requirement for 5.9.