Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Color palette is not being stored #36817

Merged
merged 1 commit into from Nov 24, 2021
Merged

Fix: Color palette is not being stored #36817

merged 1 commit into from Nov 24, 2021

Conversation

jorgefilipecosta
Copy link
Member

With #36748 and #36747 we made a regression and the color palettes are not being stored correctly.

This PR fixes the issue.

How has this been tested?

I verified as a user I could change theme, default, and custom palettes and they are stored after reloading the site editor.

@jorgefilipecosta jorgefilipecosta added Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Nov 24, 2021
@Mamaduka Mamaduka added this to 👀 Needs review in WordPress 5.9 Must-Haves via automation Nov 24, 2021
@jorgefilipecosta jorgefilipecosta force-pushed the fix/color-palettes-are-not-being-stored-correctly branch 2 times, most recently from a5b48f7 to 811b797 Compare November 24, 2021 12:21
@jorgefilipecosta jorgefilipecosta force-pushed the fix/color-palettes-are-not-being-stored-correctly branch from 811b797 to a7fef27 Compare November 24, 2021 12:25
oandregal
oandregal approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@oandregal oandregal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't been able to test manually, but changes look good.

@jorgefilipecosta jorgefilipecosta merged commit 97629ab into trunk Nov 24, 2021
@jorgefilipecosta jorgefilipecosta deleted the fix/color-palettes-are-not-being-stored-correctly branch November 24, 2021 12:56
WordPress 5.9 Must-Haves automation moved this from 👀 Needs review to ✅ Done Nov 24, 2021
@github-actions github-actions bot added this to the Gutenberg 12.1 milestone Nov 24, 2021
@aaronrobertshaw aaronrobertshaw mentioned this pull request Nov 25, 2021
Merged
7 tasks
@noisysocks noisysocks removed the Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 28, 2021
noisysocks pushed a commit that referenced this pull request Nov 29, 2021
@jorgefilipecosta @noisysocks
Fix: Color palette is not being stored (#36817)
319bc86
@noisysocks noisysocks mentioned this pull request Nov 29, 2021
Closed
@femkreations femkreations mentioned this pull request Apr 20, 2022
Closed
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oandregal oandregal oandregal approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees
No one assigned
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
No open projects
WordPress 5.9 Must-Haves
✅ Done
Milestone
Gutenberg 12.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jorgefilipecosta @oandregal @noisysocks