Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button text when no colors found #36684

Merged
merged 2 commits into from Nov 23, 2021

Conversation

KevinBatdorf
Copy link
Contributor

Description

From #36543 I've added a CTA text for when the color palette has 0 colors.

From the linked issue:

  • In the styles sidebar, in the color submenu, in the uncommon event there are no colour palettes (see image below), there should be an indicator or CTA so that users don’t need to manually navigate deep into the menus to add colours.

How has this been tested?

I tested this manually by adding/removing colors.

Screenshots

When colors is 0

Screen Shot 2021-11-19 at 5 29 23 PM

When colors > 0

Screen Shot 2021-11-19 at 4 37 52 PM

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

--

N.B. It looks like Prettier is pushing the arguments passed in to sprintf two tabs deep instead of a single tab when paired with a ternary. I've seen this elsewhere in the codebase here so may require a patch to Prettier.

@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @KevinBatdorf! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 19, 2021
@ryanwelcher ryanwelcher added [Package] Edit Site /packages/edit-site and removed [Package] Edit Site /packages/edit-site labels Nov 22, 2021
@ryanwelcher
Copy link
Contributor

Thanks for the PR @KevinBatdorf! This looks good to me but you may want to double-check that the e2e failures are not related to this change.

@KevinBatdorf
Copy link
Contributor Author

KevinBatdorf commented Nov 22, 2021

Thanks @ryanwelcher. Yeah, it seems like they just timed out. I wasn't sure about the etiquette in re-running the checks since they take awhile. I'll see if I can run them again now.

edit: I think someone with access will need to re-run them unless I make a trivial commit. I'll hold off on the latter.

Copy link
Member

@oandregal oandregal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, Kevin.

The e2e test failures look unrelated. I've restarted. If they fail again, would you mind rebasing this branch from trunk and pushing the changes again?

@oandregal oandregal merged commit 6e64edc into WordPress:trunk Nov 23, 2021
@github-actions
Copy link

Congratulations on your first merged pull request, @KevinBatdorf! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Edit Site /packages/edit-site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants