From c641fe8dd18f33bf5df8ecd07bb663bb32f6ddda Mon Sep 17 00:00:00 2001 From: Riad Benguella Date: Fri, 19 Nov 2021 12:07:34 +0100 Subject: [PATCH 1/2] Only render the site editor canvas after the base and user styles are available --- .../src/components/global-styles/global-styles-provider.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/edit-site/src/components/global-styles/global-styles-provider.js b/packages/edit-site/src/components/global-styles/global-styles-provider.js index c9c14c36a7d94..f18eff6c728be 100644 --- a/packages/edit-site/src/components/global-styles/global-styles-provider.js +++ b/packages/edit-site/src/components/global-styles/global-styles-provider.js @@ -135,7 +135,7 @@ function useGlobalStylesBaseConfig() { ).__experimentalGetCurrentThemeBaseGlobalStyles(); }, [] ); - return baseConfig; + return [ !! baseConfig, baseConfig ]; } function useGlobalStylesContext() { @@ -144,7 +144,7 @@ function useGlobalStylesContext() { userConfig, setUserConfig, ] = useGlobalStylesUserConfig(); - const baseConfig = useGlobalStylesBaseConfig(); + const [ isBaseConfigReady, baseConfig ] = useGlobalStylesBaseConfig(); const mergedConfig = useMemo( () => { if ( ! baseConfig || ! userConfig ) { return {}; @@ -153,7 +153,7 @@ function useGlobalStylesContext() { }, [ userConfig, baseConfig ] ); const context = useMemo( () => { return { - isReady: isUserConfigReady, + isReady: isUserConfigReady && isBaseConfigReady, user: userConfig, base: baseConfig, merged: mergedConfig, @@ -165,6 +165,7 @@ function useGlobalStylesContext() { baseConfig, setUserConfig, isUserConfigReady, + isBaseConfigReady, ] ); return context; From cc8526e51e0b9fb4a8e0e77a42a30566f9ed0971 Mon Sep 17 00:00:00 2001 From: Riad Benguella Date: Fri, 19 Nov 2021 12:09:26 +0100 Subject: [PATCH 2/2] Fix base global styles preloading --- lib/full-site-editing/edit-site-page.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/full-site-editing/edit-site-page.php b/lib/full-site-editing/edit-site-page.php index 3ee017395b6ee..b8c3147a94172 100644 --- a/lib/full-site-editing/edit-site-page.php +++ b/lib/full-site-editing/edit-site-page.php @@ -192,7 +192,7 @@ static function( $classes ) { '/wp/v2/themes?context=edit&status=active', '/wp/v2/global-styles/' . $active_global_styles_id . '?context=edit', '/wp/v2/global-styles/' . $active_global_styles_id, - '/wp/v2/themes/' . $active_theme . '/global-styles', + '/wp/v2/global-styles/themes/' . $active_theme, ) ), 'initializer_name' => 'initializeEditor',