Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin 18.3.0 disabled theme customizations #61582

Open
rxbracho opened this issue May 10, 2024 · 7 comments · Fixed by #61602
Open

Plugin 18.3.0 disabled theme customizations #61582

rxbracho opened this issue May 10, 2024 · 7 comments · Fixed by #61602
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended

Comments

@rxbracho
Copy link

Description

Two days ago (May 8, 2024), the Gutenberg plugin updated from 18.2.0 to 18.3.0 and it no longer finds my custom color palette or typography changes. The site seems to display properly but the editor only shows the default colors and fonts.

Step-by-step reproduction instructions

I'm not sure what to say here. I started editing today a new post and the fonts were wrong, and with the wrong color. I then noticed that my color palette had disappeared from the Site Editor, along with other options.

Looking at the blog itself shows the correct fonts, but even when trying to edit older posts that appear properly in the blog cannot be done in a true WYSISWG fashion, the fonts and other things use the default colors of the theme, for instance.

Disabling the plugin "fixed" the problem, but the default Gutenber editor available in 6.5.3 has many problems, especially in mobile devices. I don't know how to revert to 18.2.0 but I know it was working a few days ago.

Screenshots, screen recording, code snippet

Gutenberg_18 3 0_Disabled 1
Gutenberg_18 3 0_Enabled 1

Environment info

WordPress 6.5.3
Theme "Twenty twenty-three"
Guttenberg 18.3.0 shows the problem, it disappears when deactivated.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@rxbracho rxbracho added the [Type] Bug An existing feature does not function as intended label May 10, 2024
@rxbracho
Copy link
Author

UPDATE: I was able to revert to 18.2.0 and the problem went away, so it is definitely related to 18.3.0

I disabled automatic updates for now, I will be monitoring to see if the bug is fixed in a future release.

@Mamaduka Mamaduka added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label May 10, 2024
@goodpenguins
Copy link

goodpenguins commented May 11, 2024

The same.
When the Gutenberg 18.3.0 is activated, this style is applied in the post editor:

/wp-includes/css/dist/block-library/reset.css?ver=6.5.3

:where(.editor-styles-wrapper) {
     background: #fff;
     color: initial;
     font-family: serif;
     font-size: medium;
     line-height: normal;

When deactivated it's overridden by the theme.json settings.

@Mamaduka
Copy link
Member

Mamaduka commented May 11, 2024

It's probably the same report as #61565.

@rxbracho, do you have any meta boxes active in the editor, like it's reported in the other issue?

@rxbracho
Copy link
Author

rxbracho commented May 13, 2024

@Mamaduka I do not have "Custom Fields" activated in Preferences, if that is what you mean. Else, I don't know what you mean by "meta boxes active". I don't do much customizing, I use the vanilla twenty twenty-three with the "marigold" style, but I changed the color of my font, and a few other cosmetic things. To do that I built a color palette that disappeared with 18.3.0 as well.

I apologize for the delayed response, I didn't get a notification.

@Mamaduka Mamaduka reopened this May 13, 2024
@Mamaduka
Copy link
Member

@rxbracho, no problem at all. I'm going to re-open the issue. There's a plan to release a minor plugin update with the recent fix.

If that's not a problem, I would appreciate feedback on whether it fixed the issue for you because I couldn't reproduce it without the "Custom Fields" active.

Thanks again for reporting the bug!

@rxbracho
Copy link
Author

I have linked my wordpress.org and my github accounts as requested in #61602

@djcowan
Copy link

djcowan commented May 23, 2024

:where(.editor-styles-wrapper)
Happy to find this issue is being looked at; the reset is effecting typographic settings on page/post editor.
add_editor_style( ) doesn't appear to support a priorty and after_setup hook has no effect in overriding the reset.css - which is amusingly ironic given the reset css caution in the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants